tiiuae / mesh_com

ROS node for Mesh Network configuration
BSD 3-Clause "New" or "Revised" License
16 stars 17 forks source link

Code Review and cleanup #246

Closed martin-tii closed 1 year ago

martin-tii commented 1 year ago

client.py --> use of "with" for the socket, remove comments ConnectionMgr.py --> use fprint on the declaration, restructure else, if on line 73 to make it cleaner. use of with for socket handling driver.py --> remove unnecessary if entrypoint.sh --> added clean_up function header.py --> added sec_beat constants main.py --> added sys on all exits, removing comments, redone indentation main_with_menu.py --> remove 'cli' unused on return (line 53), added sys.exit(), return none on exception, added new function sbeatcount for clean up mba.py --> added 'with' to handle sockets mesh_utils.py --> refactor get_mac_neighbors, use 'with' to handle sockets mutual.py --> moved create_table as outside static function, use 'with' to open/close files. Added function server_exception for clean_up primitives.py --> use 'with' for handling files provServer.py --> add sys.exit() server.py --> added "with" to handle sockets, remove comments utils.py --> refactor update_state utils.py --> added "with" to handle sockets, refactor exchange_server wifi_ssrc.py --> small refactor on line 25

Jira_Id : MSS15-31