search

tiiuae / mesh_com

ROS node for Mesh Network configuration
BSD 3-Clause "New" or "Revised" License
16 stars 17 forks source link

SP-CRA security solutions #331

Closed anshul-tii closed 11 months ago

anshul-tii commented 12 months ago

Following files (new and modified) are added.

  1. Enhanced version of SP_CRA_v7.py script: Removes minor performance bugs in the script, better execution, and solves the issue of infinite loops issue
  2. A script containing functional and regression test cases
  3. A script containing performance test cases
  4. Scripts containing security test cases in the context of implementation
joenpera commented 11 months ago

How this thing is started in a device boot? This is now implementing a thing and it is not started

anshul-tii commented 11 months ago

started

For this, this functionality have nothing to with device boot.

anshul-tii commented 11 months ago

empty main.py file in the commit and not proper socket handling (see previous questions).

This I dont think is relevant and It has to do with some future implementatian. My entry point is in the script only

SelinaTII commented 11 months ago

How this thing is started in a device boot? This is now implementing a thing and it is not started

This feature will be started depending on the configurations received from the provisioning server (the provisioning server should specify which features to turn on Eg: SP-CRA, Jamming, IDS)

joenpera commented 11 months ago

In next update of the component or version, it might be a good idea to start to use static typing in some level. Static typing helps to understand what functions should return as type or which type of parameters is expected to be passed in.

Also it would be good to start to use also some python code style checker.

joenpera commented 11 months ago

How this thing is started in a device boot? This is now implementing a thing and it is not started

This feature will be started depending on the configurations received from the provisioning server (the provisioning server should specify which features to turn on Eg: SP-CRA, Jamming, IDS)

Provisioning server will provide only certificates. Provisioning Server functionality and provided services are defined by Solita.

anshul-tii commented 11 months ago

In next update of the component or version, it might be a good idea to start to use static typing in some level. Static typing helps to understand what functions should return as type or which type of parameters is expected to be passed in.

Understood, Thanks for the feedback. I will keep this comment in future.

SelinaTII commented 11 months ago

How this thing is started in a device boot? This is now implementing a thing and it is not started

This feature will be started depending on the configurations received from the provisioning server (the provisioning server should specify which features to turn on Eg: SP-CRA, Jamming, IDS)

Provisioning server will provide only certificates. Provisioning Server functionality and provided services are defined by Solita.

What I understood from the new requirements discussions is that the provisioning server will (with future work) provide the certificates to setup the upper macsec/ batman as well as configurations such as which 2.0 features should be started. I am planning on starting these features from main.py, but as of now it is empty.

joenpera commented 11 months ago

How this thing is started in a device boot? This is now implementing a thing and it is not started

This feature will be started depending on the configurations received from the provisioning server (the provisioning server should specify which features to turn on Eg: SP-CRA, Jamming, IDS)

Provisioning server will provide only certificates. Provisioning Server functionality and provided services are defined by Solita. @TIISR And with current terms from MDM server?

TIISR here, for some reason GitHub does not let me reply to this particular comment but it lets me edit @joenpera 's comment: until SP-CRA can self-configure and proves to not affect any other software component (otherwise we have too many things to debug all at the same time 🙂) the idea is to have it disabled by default and then on a per-device basis easily enabled by MDM Server configuration applied by MDM Agent in CommsController. To avoid confusion let's please use the "provisioning" word only in reference to the Flight & Mission Operations (FMO) stuff distributed by NATS and only present in some use-cases, as opposed to our MDM present in all use-cases.