search

tiiuae / mesh_com

ROS node for Mesh Network configuration
BSD 3-Clause "New" or "Revised" License
16 stars 17 forks source link

MS2.0 MDM/CBMA MVP Content #402

Closed joenpera closed 8 months ago

joenpera commented 9 months ago

Contains changes related to tickets: SECO-3573, SECO-3578, SECO-3574, SECO-3578, SECO-3806, SECO-3497, SECO-3577, SECO-3802

Relates to tc_distro side PR 195

saauvine commented 8 months ago

How shall we proceed with this PR? Review as is or should we put cbma still under that feature flag and the consider this as ready for review?

joenpera commented 8 months ago

How shall we proceed with this PR? Review as is or should we put cbma still under that feature flag and the consider this as ready for review?

If CBMA is kept disabled, then we need to change also default configuration generation to support CBMA disabled mode. Now we are clearing some configuration items by assumption that CBMA is enabled.

saauvine commented 8 months ago

How shall we proceed with this PR? Review as is or should we put cbma still under that feature flag and the consider this as ready for review?

If CBMA is kept disabled, then we need to change also default configuration generation to support CBMA disabled mode. Now we are clearing some configuration items by assumption that CBMA is enabled.

True and we probably don't want to put any energy to that. I hope nobody is developing things upon mesh-11s._nats.sh before this gets merged. Nobody in UAE is testing these changes before things gets merged.

pentestiing commented 8 months ago

This PR won't be tested from our side until CBMA MVP is merged into develop. So, if you need some commits from here for any MDM MVP PRs you are working on, I'd recommend to cherry pick it and then remove it from this one :moon_cake:

joenpera commented 8 months ago

This PR won't be tested from our side until CBMA MVP is merged into develop. So, if you need some commits from here for any MDM MVP PRs you are working on, I'd recommend to cherry pick it and then remove it from this one 🥮

We are aware of the situation and we can wait this one and then do a big bang :boom: