tijder / SmsMatrix

A simple SMS <--> Matrix bridge.
https://matrix.to/#/#smsmatrix:matrix.org
GNU General Public License v3.0
216 stars 36 forks source link

Persistent notification for Matrix Service #29

Closed ghost closed 5 years ago

ghost commented 5 years ago

Tested on Android 8.1.0

This will show a Persistent notification while the matrix service is running.

Please let me know if you would like this done differently. I'm new to Java/Android.

tijder commented 5 years ago

Nice feature to add, but maybe its better to give the user a chooce if they want the notification.

tijder commented 5 years ago

When the user chooce not to show the notification. Give then a warning that the bridge can be stopped by the android os and will start running again after receiving a sms. When choosing to let the app be killed by the os this will increase the battery time.

ghost commented 5 years ago

Fair enough. I know you can disable notification channels in Android 8.1.0 which will hide the persistent notification I set up. However, I agree that it's better to ask the user in the app. I have no idea how to do this so I'll remove the request and send a new one if/when I write the code.