mytimeline refactor

[vinaybadgujar102]

resolves #1773 resolves #1814

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
zinzen	✅ Ready (Inspect)	Visit Preview	Nov 5, 2024 1:41am

[tijlleenders]

@vinaybadgujar102 Is 'classnames' really necessary and widely used/revognized amongst react programmers?

It requires learning additional syntax - that even if not conplicated makes it harder to read/edit?

Is this utility dev 'sugar' only or does it also impact build size?

[vinaybadgujar102]

@tijlleenders, I believe using library for managing conditional class names could be beneficial. We have many instances in our codebase where we handle conditional class names, and its well-known practice to use a library for this purpose.

The syntax for these libraries is generally straightforward and easy to understand at a glance.

This libraries impacts the build size but these libraries are typically lightweight. Regarding build size concerns, I found an alternative library, clsx, which is smaller and offers performance improvements compared to the one I initially used.

[tijlleenders]

How many is many?
Can you count the files and lines of code where this would improve the readability?

It is not strictly required for this PR functionality so this should be proposed as a separate PR that will also fix all the places where this has value.

[vinaybadgujar102]

@Tushar-4781, In #1999, we're adding 'Reminders' to the timeline, which comes with its own logic. This will make the current timeline component larger and harder to manage. By breaking the component into smaller parts, it'll be easier to handle these new changes and keep the code more organized.

[Tushar-4781]

@vinaybadgujar102 in that case you can continue that in this branch.