fix bugs related to deleted and archived goal items

[vinaybadgujar102]

resolves #1991

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
zinzen	✅ Ready (Inspect)	Visit Preview	Sep 1, 2024 10:31am

[vinaybadgujar102]

Yes this is nice. If you can, add the new goal 'pling' sound when restoring the goal.

done

[Tushar-4781]

@tijlleenders Please check the delete functionality again :) @vinaybadgujar102 can you please try collab again now. I've updated the PR

[Tushar-4781]

Previously deleting a goal was taking too long because of the sound.

[Tushar-4781]

@tijlleenders what are you expecting in that case ? isn't that a natural behavior ?

[tijlleenders]

@Tushar-4781 The same behavior as when it would be in 'done'. This is currently working for root goals - but not for subGoals.

[tijlleenders]

The use case is if you mark something as done - then change your mind. You don't want to have to navigate away first.

[vinaybadgujar102]

@Tushar-4781 the dot is correctly disappearing now after accepting changes according to your comment. Additionally I encountered some bugs related to share functionality for which I will create issues once I confirm them.

When I complete multiple goals in Daily routines then select the circle on one of them, nothing happens.

@tijlleenders, I fixed this in latest commit.

[Tushar-4781]

@vinaybadgujar102 I think there's a more efficient way to handle this. Since the component already has access to the length of the goals, it might be better to use that directly rather than passing it in as props

[vinaybadgujar102]

@tijlleenders, I agree. Creating tests for core features will help minimize redundant efforts in fixing regressions introduced by new changes.

[Tushar-4781]

@tijlleenders can we have test in seperate pr

[tijlleenders]

@tijlleenders can we have test in seperate pr

Yes, of course.

[tijlleenders]

I noticed now that crossing out a done item and then deleting an item will move the done item to done while moving the deleted to trash.

I would expect only the deleted item moving to trash, and the done being crossed out untill you navigate away and back again.

Screencast from 2024-09-02 12-29-00.webm

[Tushar-4781]

@vinaybadgujar102 are u fixing it or do you want me to fix it ?

[vinaybadgujar102]

@vinaybadgujar102 are u fixing it or do you want me to fix it ?

It would be helpful if you fix this.

[tijlleenders]

Holding off on 'fixing' this as state update exceptions on default React get complicated.