search

tijmenvangulik / Ergometerspace

Documentation for ergometer-space
https://ergometer-space.org
Other
19 stars 7 forks source link

App not releasing plugin id on plugin delete #2

Closed dariomarciano closed 6 years ago

dariomarciano commented 6 years ago

When I add a plugin from file, delete it, then add it again the app won't let me, throwing an "Application plugin with same id already exists" error

tijmenvangulik commented 6 years ago

Thank you for reporting, I will work on this. I have also upgraded typescript and have changed to another plugin editor. So if you intend to write your own plugins, get ready for major changes. The web edition is already upgraded

tijmenvangulik commented 6 years ago

I could not yet repeat your issue. Dit you get an error while installing the plugin? (check the console) When the plugin is not correctly initialized the uninstall may go wrong. It may have to do with the mobile apps which still run the old version and the web which is already upgraded to the new typescript. And I assume that you edit it the web edition. As temporary work around , just kill the app and start it again. I will update the android app as soon as possible.

dariomarciano commented 6 years ago

Here's what I do: start the app (or open the web page, it's the same) click menu -> plugins; it lists no plugin click add from file Nothing loads, then I get an "ApplicationPlugin with same id dariomarciano.ergWorkout already exists". Attached you'll find the plugin, ofc delete the .txt extension, had to add it coz of github.

ergWorkout.JSON.txt

tijmenvangulik commented 6 years ago

I can repeat your issue. I have fixed it in my code. I will look this evening at the heart rate problem, Hopefully I can fix them both before I post an update

tijmenvangulik commented 6 years ago

I fixed this issue and rolled out an new release. (the fixed is in 2.011) I have added another feature which can be helpful when writing plugs: When you save the plugin code it will now automatically reload the widget which where controlled by the plugin. This saves some time when debugging.