tijn / pause-night-light

Pause Gnome Night Light for 10 seconds
https://extensions.gnome.org/extension/1327/pause-night-light/
GNU General Public License v3.0
10 stars 2 forks source link

Setting to choose lenght of pause #3

Closed forteller closed 6 years ago

forteller commented 7 years ago

This is really great! Thanks! But it would be useful for even more people if there was a setting that let you choose for how long the pause should last.

Maybe you could even let each user add more "pause buttons", so that you could have different lengths for different uses? Like for example have both a "Pause for 10 seconds" and a "Pause for 3 hours". But this is less important :)

tijn commented 7 years ago

Well, you're not wrong, obviously that could be useful, but I have some remarks:

tijn commented 6 years ago

Closing this because of lack of conversation. Feel free to reopen if there are new insights to be shared.

forteller commented 6 years ago

Hey, @tijn! I really appreciate your fast reply, and I'm sorry I didn't get around to answer you any sooner! Here's my proposal for a settings screen. The slides should obviously be at different places along the scale, but I couldn't figure out how to do that in the software I used.

screenshot from 2017-11-11 01-27-15

tijn commented 6 years ago

Right, but how would you open the settings menu? Where would you place the settings button?

And, even more important, do you @forteller have any specific request for certain time spans? Do you have a specific need or use case in mind?

forteller commented 6 years ago

Extensions has a built in system for including settings. The button is available from https://extensions.gnome.org/local/ and from Gnome Tweaks, if you have that installed.

I'd love to have 1 hour and 2 hours as time spans to select. That way I can start on a tv episode (1 hour) or movie (2 hours) right before midnight without the night light turning on in the middle of watching :)

forteller commented 6 years ago

I was still hoping you would implement this at some point. But I see now that you've closed this issue. So, should I just uninstall then, instead of having it installed, but turned off, waiting for an update?

This is your project, you of course do what you want with it :)

tijn commented 6 years ago

Yes, that's correct. Your proposal is completely out of scope for this project.

I made you a small script that I think will work better for your use case:

#!/bin/sh
gsettings set org.gnome.settings-daemon.plugins.color night-light-enabled false
sleep 5
mplayer $@ 
gsettings set org.gnome.settings-daemon.plugins.color night-light-enabled true

Save this as /usr/local/bin/play-tv-episode or whatever name you would like it to have and chmod +x it.

Then run it like this:

play-tv-episode [OPTION]... FILENAME(S)

This will play your video with night light off, and when it's done, it'll enable night light again. You can easily substitute mplayer with vlc or whichever video-player you prefer and set some flags if you wish to do so. It's also possible to register this script as an alternative video player for video files in Gnome if you don't like using the terminal.

forteller commented 6 years ago

Oh, wow. That's awesome! Thanks! :)