search

tijsverkoyen / CssToInlineStyles

CssToInlineStyles is a class that enables you to convert HTML-pages/files into HTML-pages/files with inline styles. This is very usefull when you're sending emails.
BSD 3-Clause "New" or "Revised" License
5.8k stars 187 forks source link

CI: build also on Windows #224

Closed mhujer closed 2 years ago

mhujer commented 2 years ago

Let's build also on Windows to prevent issues similar to #204 in the future.

stof commented 2 years ago

Looks like your git config --global core.autocrlf false trick does not work properly here. It still have a test failure where the expected output uses \r\n, which is not the case in the source code. I think you also need git config --global core.eol lf

mhujer commented 2 years ago

@stof Yes, that fixes it 👍 (I've amended the commit and verified the build in my fork)