tikhop / TPInAppReceipt

Reading and Validating In App Purchase Receipt Locally.
MIT License
631 stars 93 forks source link

Some methods are not callable from Objective-C #95

Closed ortekka closed 2 years ago

ortekka commented 2 years ago

It looks like the InAppReceipt_Objc wrapper class exposes only a subset of methods available in the InAppReceipt class.

For example, while verify() is available, and can be called from Objective-C in this way:

NSError * receiptError = nil;
if([receipt verifyAndReturnError:&receiptError])
{
    // verification successful
}

other methods such as isEligibleForIntroductoryOffer() are not exposed from the wrapper.

tikhop commented 2 years ago

Hi @ortekka, thanks for reporting this. I will implement all missed functionality when I have a chance. Currently, objc wrapper is in low priority and if you need something quickly you are more than welcome to make a PR.

ortekka commented 2 years ago

Hi Pavel,

Thanks for your reply.

I understand the ObjC wrapper is low priority for you. In fact, I'm using TPInAppReceipt in a legacy project after successfully integrating it in a much more modern SwiftUI codebase.

Following your suggestions, I made a PR for the change I need:

https://github.com/tikhop/TPInAppReceipt/pull/96/commits

This is my first PR ever, BTW, so please be patient if I made any rookie mistakes.

Best regards,

                -- marco

On 12 Dec 2021, at 11:33, Pavel T @.***> wrote:

Hi @ortekka, thanks for reporting this. I will implement all missed functionality when I have a chance. Currently, objc wrapper is in low priority and if you need something quickly you are more than welcome to make a PR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

tikhop commented 2 years ago

Hi @ortekka,

Just merged your PR and going to release new version. Thanks for your contribution.