search

tiki-bar / app-shopify-extensions

Integrate mytiki.com with your Shopify Store
https://mytiki.com
GNU Affero General Public License v3.0
2 stars 0 forks source link

Blackbox test Shopify App #106

Open sfaria27 opened 10 months ago

sfaria27 commented 10 months ago

Try to break Shopify app before sending in for Shopify review

ricardobrg commented 10 months ago

Adding the necessary fix as comments to be converted into issues.

ricardobrg commented 10 months ago

If a product discount has an "Applies to" filter, it breaks TIKI sqlite database when accepted:

Uncaught SqliteException(11): while executing, database disk image is malformed, database disk image is malformed (code 11)
  Causing statement:     CREATE TABLE IF NOT EXISTS txn (
      id BLOB PRIMARY KEY NOT NULL,
      merkel_proof BLOB,
      version INTEGER NOT NULL,
      address BLOB NOT NULL,
      contents BLOB NOT NULL,
      asset_ref TEXT NOT NULL,
      block_id BLOB, 
      timestamp INTEGER NOT NULL,
      user_signature BlOB NOT NULL,
      app_signature BlOB,
      FOREIGN KEY(block_id) 
        REFERENCES block(id)
     ); 
    , parameters: 
    at Object.d (https://unpkg.com/@mytiki/tiki-sdk-js@2.1.4/dist/index.js:1:12959)
    at Object.A5 (https://unpkg.com/@mytiki/tiki-sdk-js@2.1.4/dist/index.js:1:153256)
    at rc.c0 (https://unpkg.com/@mytiki/tiki-sdk-js@2.1.4/dist/index.js:1:519417)
    at rc.cz (https://unpkg.com/@mytiki/tiki-sdk-js@2.1.4/dist/index.js:1:519557)
    at https://unpkg.com/@mytiki/tiki-sdk-js@2.1.4/dist/index.js:1:143764
    at G.a (https://unpkg.com/@mytiki/tiki-sdk-js@2.1.4/dist/index.js:1:42343)
    at zE.$2 (https://unpkg.com/@mytiki/tiki-sdk-js@2.1.4/dist/index.js:1:188691)
    at zp.$1 (https://unpkg.com/@mytiki/tiki-sdk-js@2.1.4/dist/index.js:1:188587)
    at z2.v4 (https://unpkg.com/@mytiki/tiki-sdk-js@2.1.4/dist/index.js:1:200965)
    at z2.jk (https://unpkg.com/@mytiki/tiki-sdk-js@2.1.4/dist/index.js:1:201017)
ricardobrg commented 10 months ago

The discount details are not showing correct values.

Steps to reproduce

117

ricardobrg commented 10 months ago

The discount/license accepted cookies should be saved faster. If the user accepts the offer and navigates faster to another page, the banner will keep showing because the decision wasn't saved.

This might be the expected behaviour, since we need to make sure that the user choice was correctly saved. To be defined the best approach.

ricardobrg commented 10 months ago

Banner should not show in contact screen and should show in catalog screen.

Technically should show in all screens in the subdomain

ricardobrg commented 10 months ago

Add an option to cap the number of itens in product discount

For example, if you have a 10% discount and add 3 items, it will discount 10% off of every item.

ricardobrg commented 10 months ago

fix the sizing of the banner for screens below 1024px. Related to https://github.com/tiki/tiki-sdk-js/issues/135

sfaria27 commented 9 months ago

Minimum order discount should be ≥ not >

ricardobrg commented 9 months ago

If all combinations boxes are selected just shipping is registered

Possible causes:

ricardobrg commented 9 months ago

Above comments fixed in https://github.com/tiki/apps-shopify-extensions/issues/117 https://github.com/tiki/apps-shopify-extensions/issues/118 fix: banner should show in all screens 4ab0f94 fix: order min value/qty >= 34857c9

Working on #116

ricardobrg commented 9 months ago

Blocked by https://github.com/tiki/publish-sdk-js/issues/108