search

tiki-bar / app-shopify-extensions

Integrate mytiki.com with your Shopify Store
https://mytiki.com
GNU Affero General Public License v3.0
2 stars 0 forks source link

Verify signature when saving a user discount #60

Closed ricardobrg closed 11 months ago

ricardobrg commented 11 months ago

As a developer I need to verify the signature of the user discount to be saved in the backend so that it prevents bad use of the endpoint

What it is now

The endpoint for saving user discounts does not verify the signature.

What it should be

The endpoint for saving user discounts verifies the signature and blocks not signed requests.

Technical details

There is an issue in TIKI SDK JS that prevents the signature to be verified.

Acceptance criteria

  1. Non signed requests are blocked in user/discount endpoint
mike-audi commented 11 months ago

fixed in release sdk-js 2.1.4