Blackbox test Shopify App

[sfaria27]

Try to break Shopify app before sending in for Shopify review

[ricardobrg]

Adding the necessary fix as comments to be converted into issues.

[ricardobrg]

If a product discount has an "Applies to" filter, it breaks TIKI sqlite database when accepted:

Uncaught SqliteException(11): while executing, database disk image is malformed, database disk image is malformed (code 11)
  Causing statement:     CREATE TABLE IF NOT EXISTS txn (
      id BLOB PRIMARY KEY NOT NULL,
      merkel_proof BLOB,
      version INTEGER NOT NULL,
      address BLOB NOT NULL,
      contents BLOB NOT NULL,
      asset_ref TEXT NOT NULL,
      block_id BLOB, 
      timestamp INTEGER NOT NULL,
      user_signature BlOB NOT NULL,
      app_signature BlOB,
      FOREIGN KEY(block_id) 
        REFERENCES block(id)
     ); 
    , parameters: 
    at Object.d (https://unpkg.com/@mytiki/tiki-sdk-js@2.1.4/dist/index.js:1:12959)
    at Object.A5 (https://unpkg.com/@mytiki/tiki-sdk-js@2.1.4/dist/index.js:1:153256)
    at rc.c0 (https://unpkg.com/@mytiki/tiki-sdk-js@2.1.4/dist/index.js:1:519417)
    at rc.cz (https://unpkg.com/@mytiki/tiki-sdk-js@2.1.4/dist/index.js:1:519557)
    at https://unpkg.com/@mytiki/tiki-sdk-js@2.1.4/dist/index.js:1:143764
    at G.a (https://unpkg.com/@mytiki/tiki-sdk-js@2.1.4/dist/index.js:1:42343)
    at zE.$2 (https://unpkg.com/@mytiki/tiki-sdk-js@2.1.4/dist/index.js:1:188691)
    at zp.$1 (https://unpkg.com/@mytiki/tiki-sdk-js@2.1.4/dist/index.js:1:188587)
    at z2.v4 (https://unpkg.com/@mytiki/tiki-sdk-js@2.1.4/dist/index.js:1:200965)
    at z2.jk (https://unpkg.com/@mytiki/tiki-sdk-js@2.1.4/dist/index.js:1:201017)

[ricardobrg]

The discount details are not showing correct values.

Steps to reproduce

• create an discount
• open the discount in the menu
• check the values are not matching

117

[ricardobrg]

The discount/license accepted cookies should be saved faster. If the user accepts the offer and navigates faster to another page, the banner will keep showing because the decision wasn't saved.

This might be the expected behaviour, since we need to make sure that the user choice was correctly saved. To be defined the best approach.

[ricardobrg]

Banner should not show in contact screen and should show in catalog screen.

Technically should show in all screens in the subdomain

[ricardobrg]

Add an option to cap the number of itens in product discount

For example, if you have a 10% discount and add 3 items, it will discount 10% off of every item.

[ricardobrg]

fix the sizing of the banner for screens below 1024px. Related to https://github.com/tiki/tiki-sdk-js/issues/135

[sfaria27]

Minimum order discount should be ≥ not >

[ricardobrg]

If all combinations boxes are selected just shipping is registered

Possible causes:

• the form is not sending the correct value
• our backend is not saving correclty this option
• Shopify just allows product discounts combined with shipping discounts and the Combinations UI should be updated (most likely)

[ricardobrg]

Above comments fixed in https://github.com/tiki/apps-shopify-extensions/issues/117 https://github.com/tiki/apps-shopify-extensions/issues/118 fix: banner should show in all screens 4ab0f94 fix: order min value/qty >= 34857c9

Working on #116

[ricardobrg]

Blocked by https://github.com/tiki/publish-sdk-js/issues/108