search

tikotzky / faker-rs

A library for generating fake data such as names, addresses, and phone numbers.
28 stars 5 forks source link

Compile on Nightly #3

Closed nixpulvis closed 8 years ago

nixpulvis commented 8 years ago

Get this crate working on nightly Rust again.

To Do

tikotzky commented 8 years ago

Hi @nixpulvis,

Thanks for this PR!

As you noticed this project has been a little dormant :cry: I keep meaning to get back into and update it but unfortunately time is working against me.

With that being said if you're open to it I would love to give you collab access so you can get the project running again on stable.

Lemme know and I'll get you added :smile:

nixpulvis commented 8 years ago

Sure thing. My current plans are to get things working on stable and nightly (mostly done) then abstract some of the code with a few traits, possibly changing the interface a tiny bit. And work on a way to avoid allocations.

tikotzky commented 8 years ago

Sound great!

I added you as collab...

feel free to make things awesome :smiley:

nixpulvis commented 8 years ago

Should I still work through PRs waiting on your input?

tikotzky commented 8 years ago

I think working on PRs is nice since it allows everyone to follow along.

I'm ok with you merging your work once its complete, but I'll wait for @sethpollack to chime in since he did a lot of work on this as well.

sethpollack commented 8 years ago

Yeah PR is good. I haven't touched Rust for a while (I'm a little rusty), but if you want to collab with me I would love to add localization to this project.

nixpulvis commented 8 years ago

I'm working on some generalizations now. I'll push soon(ish)

tikotzky commented 8 years ago

:+1: :+1: :+1:

nixpulvis commented 8 years ago

Do I have permissions to push to crates.io?

tikotzky commented 8 years ago

adding you now...

tikotzky commented 8 years ago

done. lemme know if you have issues pushing to crates.io

nixpulvis commented 8 years ago

Done :tada:

tikotzky commented 8 years ago

awesome!