search

tikservices / html5-video-everywhere

Higher performance and stable video watching experience on the web
https://h5vew.tik.tn/
Mozilla Public License 2.0
118 stars 51 forks source link

[Now part of Firefox 49.0] Repeat button in control bar #53

Closed davidhedlund closed 9 years ago

davidhedlund commented 9 years ago

html5-video-everywhere--repeat_button_request

The Firefox add-on Media loop is described as a "Menu item to control [HTML5] audio/video loop" - https://addons.mozilla.org/en-US/firefox/addon/media-loop/. Media loop can be used to repeat HTML5 videos on any website, not just YouTube.

Can you to implement Media loop in HTML5 Videos Everywhere! and a Repeat button that uses it in Control. Refer to the red marked repeat icon located bottom right at the above modified screenshot?

HTML5 Video Everywhere is currently part of GNU IceCat, if we add the repeat button there is a great chance that other developers add the repeat button to their web players.

salixh5 commented 9 years ago

My work-around right now: right click inspect the video element and add the loop argument to the tag.

davidhedlund commented 9 years ago

@jeifour "Inspect Element (Q)"?

Also, how do you add the loop argument?

salixh5 commented 9 years ago

@davidhedlund Yes, "Inspect Element (Q)" probably in an English version of Firefox. Just double-click on the video tag and add an attribute by writing something like loop="loop", then save this and close the dev tools. That particular video will now always loop, but you will have to do it everytime that you want to make videos loop. This works with every pure html5 video on the web btw. Quick demo (sorry flv/mp4 video): https://a.pomf.se/fooocq.flv

jomo commented 9 years ago

There's actually a plugin for this called Media Loop:

image

davidhedlund commented 9 years ago

Thank you for helping me out dear @jomo, you made my day! I updated the lead by adding this great add-on. @jeifour please have a look.

davidhedlund commented 9 years ago

@lejenome I made a screenshot for you to better explain the feature request. By the way, can you please label this issue "Feature"?

salixh5 commented 9 years ago

I don't think your points get across any better if you keep spamming issue trackers, honestly. If the feature is so vital for you that you can't wait for proper answers of project maintainers, you're free to fork this repository; this add-on is free software after all.

davidhedlund commented 9 years ago

@jeifour I just asked him to label the issue.

lejenome commented 9 years ago

implemented on context menu and addon manager interface on lastest update. Adding buttons to the player control bar depends on using an other video player implementation other than firefox default video player.

jomo commented 9 years ago

I think this feature request should go towards Firefox, since this plugin just replaces custom players with Firefox' native HTML video player.

(Or you just use the plugin I linked you to)

davidhedlund commented 9 years ago

@lejenome I posted this enhancement in https://bugzilla.mozilla.org/show_bug.cgi?id=1168681

davidhedlund commented 9 years ago

It is great that repeat support for YT has been added. But it does not yet work in other websites like the add-on Media loop.

lejenome commented 9 years ago

fixed, will be included on next release

davidhedlund commented 9 years ago

@lejenome Please make sure that it do not interfere with Media loop. Enable/disable Media loop braked HTML5 Video Everywhere when I tested.

lejenome commented 9 years ago

support for video repeat on other sites is added on latest release

flyingzebras commented 9 years ago

@lejenome Not working in PornHub NETWORK sites: examples

lejenome commented 9 years ago

only sites supported by the extension. Porn sites are not supported yet.

flyingzebras commented 9 years ago

@lejenome Thank you for letting me know and thank you for adding this feature to other websites!

davidhedlund commented 9 years ago

@lejenome Media loop repeat HTML5 videos in all websites, is it possible to implement it in HTML5 Video Everywhere?

lejenome commented 9 years ago

Because the extension currently support only 6 websites. Adding just loop support to other websites is not this extension job, you should use other extension to add loop support for all sites.

On Sun, May 24, 2015 at 10:36 PM, davidhedlund notifications@github.com wrote:

@lejenome https://github.com/lejenome Media loop repeat HTML5 videos in all websites, why didn't you just implement it?

— Reply to this email directly or view it on GitHub https://github.com/lejenome/html5-video-everywhere/issues/53#issuecomment-105063809 .

davidhedlund commented 9 years ago

@lejenome Oh, I thought I used HTML5 Video Everywhere in all websites but I can figure that out now since you added About. Thanks.

jomo commented 9 years ago

because there are a lot of websites on the internet. Make a PR for sites you want supported?

lejenome commented 9 years ago

Websites support is tracked on milestones [1]. PR are welcome.

Some issues [2] are blocking support for new websites mainly MSE extension support and flash player handling.

[1] https://github.com/lejenome/html5-video-everywhere/milestones [2] https://github.com/lejenome/html5-video-everywhere/issues?q=is:open+is:issue+label:%22help+wanted%22

davidhedlund commented 9 years ago

@lejenome Interesting, thank you for the information. Where can I access Milestones from https://github.com/lejenome/html5-video-everywhere ?

lejenome commented 9 years ago

https://github.com/lejenome/html5-video-everywhere/milestones

davidhedlund commented 9 years ago

@lejenome Yes, I just wonder in which HTML pages its located too.

jomo commented 8 years ago

The latest Firefox release includes a loop option, see this beautiful screenshot:

screenshot

Now there's two loop options, the one added by this plugin doesn't seem two work. I guess it can be removed?

davidhedlund commented 8 years ago

@jomo Aswome! - I actually submitted this idea.