tiktaalik-dev / blueproximity

Desktop application to lock/unlock your screen automatically based on detecting how close it's to another Bluetooth device (e.g. your mobile phone).
GNU General Public License v2.0
93 stars 28 forks source link

Introduced AppImage build system #12

Closed ebababi closed 3 years ago

ebababi commented 3 years ago

I believe a good way to ease access to this application is distributing as an AppImage.

Leveraging appimage-builder a configuration has been created to generate an AppImage bundle of the project. Minimal changes to the rest of the code base include:

One may explore GitHub Actions to automatically build the AppImage bundle.

I have tried the generated AppImage on Ubuntu 20.04, however I haven't tried on any other distribution.

tiktaalik-dev commented 3 years ago

Hi Nikolaos,

Sorry for the late reply, it's been kind of hectic for me lately. Thanks so much for this contribution! It's a great idea making an AppImage! But may I ask for you to create a '/feature/AppImage' branch, please? Or if you allow it in your pull request maybe I could do it myself. I reckon GitHub has that feature, if I remember correctly. Thanks in advance for your help to improve this software!

Cheers, Rigo

ebababi commented 3 years ago

Hi Rigo,

Of course you can do any modification you see fit.

I'm not sure how to open a new branch pulling from my repository, but if you can feel free.

Regards,

Nikolaos

tiktaalik-dev commented 3 years ago

Hi again Nikolaos, Thanks again for your contribution :smile: I'm going to experiment now with this configuration and then merge it on the master branch. Please let me know how do you want to be credited for your work when I do the final merge. Maybe you want to add an email address next to your name? Or your GitHub username?

Cheers, Rigo.

ebababi commented 3 years ago

Hi Rigo,

Thank you for the consideration. I have no preference and even no mention at all is also OK. I leave it to your discretion.

Regards, Nikolaos