search

tiktaalik-dev / blueproximity

Desktop application to lock/unlock your screen automatically based on detecting how close it's to another Bluetooth device (e.g. your mobile phone).
GNU General Public License v2.0
93 stars 28 forks source link

fix getting objects from builder #19

Open vhdirk opened 2 years ago

vhdirk commented 2 years ago

The function get_widget doesn't exist anymore

tiktaalik-dev commented 2 years ago

Hi @vhdirk,

Thanks for contributing this code! And sorry for the very late reply! I'll check it and merge it as soon as possible. But may I ask for a bit of context, please? I'm not very acquainted with these functions. Was get_widget made obsolete? If so do you know from what GTK version onwards? I'd like to make sure we don't break any compatibility for people currently running the software. If you could help me out with that I'd greatly appreciate it! Of course I will credit your work on the Contributors list. Thanks again and I look forward to your reply.

Cheers, Rigo.

tiktaalik-dev commented 2 years ago

By the way, @vhdirk could you move your pull request to a new branch, please? Use a prefix like the tag I assigned to this pull request (e.g improvement/fix-get-widget). That way I can try the code before merging it to the master branch.

Cheers.

liran-funaro commented 1 year ago

I also experienced this issue with Ubuntu 22.04, and Python 3.10.4. @tiktaalik-dev You can fetch the PR without "moving" it to a branch. See checking-out-pull-requests-locally.

In short:

git fetch origin pull/19/head:PR19
git checkout PR19
stefanct commented 6 months ago

I had to patch this too (I noticed because the device selector button didn't work). Are you still active, @tiktaalik-dev, or is it time to fork this again already? :P I can add a PR that has no white-space changes and/or is on its own branch if need be but get_widget should definitely be replaced ASAP.

tiktaalik-dev commented 6 months ago

Hi @stefanct, @liran-funaro, and @vhdirk,

I'm sorry for the very late reply! Life has a habit of getting in the way of what I intend to do. I expect to review the code soon and later on probably will look into building a new app based on Blueproximity, as I see that there is actually interest in such a tool. Obviously, under a new name... But please, feel free to fork it if I take too long. After all, that's what I did back then as well :-)

Cheers, Rigo.