search

tikv / agatedb

A persistent key-value storage in rust.
Apache License 2.0
829 stars 74 forks source link

Feature: Ingest External SST #188

Open wangnengjie opened 2 years ago

wangnengjie commented 2 years ago

Signed-off-by: wangnengjie 751614701@qq.com

See details in: https://github.com/tikv/agatedb/issues/187

wangnengjie commented 2 years ago

The next_txn_ts won't update when reopening db? @GanZiheng

GanZiheng commented 2 years ago

The next_txn_ts won't update when reopening db? @GanZiheng

Yes... I remember it is set to 1.

wangnengjie commented 2 years ago

Yes... I remember it is set to 1.

Well, that's... amazing... I debug a while for my failed test. I think I should make another pr to make it works right.

wangnengjie commented 2 years ago

Generally done. You can have a look. @GanZiheng

BTW, the rustfmt.toml use many flags that are only available in nightly channel while CI use stable channel. So it just failed though I run make format under nightly channel.

GanZiheng commented 2 years ago

Generally done. You can have a look. @GanZiheng

BTW, the rustfmt.toml use many flags that are only available in nightly channel while CI use stable channel. So it just failed though I run make format under nightly channel.

We currently use stable channel for the sake of avoiding CI failing too often. I think there is a format error in this version of code.

wangnengjie commented 2 years ago

Generally done. You can have a look. @GanZiheng BTW, the rustfmt.toml use many flags that are only available in nightly channel while CI use stable channel. So it just failed though I run make format under nightly channel.

We currently use stable channel for the sake of avoiding CI failing too often. I think there is a format error in this version of code.

As what I have said, rustfmt.toml use many flags that are only available in nightly channel which makes the result of format different with stable channel. I will use stable channel to format the code later. So why not just remove all these flags that only available in nightly channel?

Does CI often failed in nightly channel? I saw that all tests (except the first one) run in nightly channel for the support of sanitizer...

GanZiheng commented 2 years ago

Does CI often failed in nightly channel? I saw that all tests (except the first one) run in nightly channel for the support of sanitizer...

Specifically, failed due to the clippy check. We can consider remove these flags or just turn back to nightly channel, I think that's not matter.

codecov[bot] commented 2 years ago

Codecov Report

Merging #188 (f241a88) into master (070ff80) will increase coverage by 1.16%. The diff coverage is 94.85%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #188 +/- ## ========================================== + Coverage 89.63% 90.80% +1.16% ========================================== Files 39 40 +1 Lines 8838 9679 +841 ========================================== + Hits 7922 8789 +867 + Misses 916 890 -26 ```