search

tikv / client-c

The C++ TiKV client used by TiFlash.
Apache License 2.0
40 stars 47 forks source link

<Poco> dependency #3

Open doublex opened 5 years ago

doublex commented 5 years ago

@hanfei1991 Would it be possible to create the "c-client" only with a dependency to "grpc" (e.g. to void "Poco")?

hanfei1991 commented 5 years ago

Well, Is there a better way to print log ?

gggin commented 3 years ago

https://github.com/amrayn/easyloggingpp ?

tisonkun commented 3 years ago

Well, Is there a better way to print log ?

@hanfei1991 Do we use Poco for logging only?

I assume the problem with Poco dependency is that it might conflict with user application's Poco.

For logging, in Java community most project written based on the Facade(e.g. slf4j) and the real runtime set the implementation. @gggin can your alternative choice avoid library link but only headers?

Otherwise #63 can resolve this issue if the concern is system-wise pre-installed library requirement.

zanmato1984 commented 2 years ago

PR https://github.com/tikv/client-c/pull/84 may ease this problem. It works for both system-wide pre-installed poco, and bundled poco in an outer project.