search

tikv / client-go

Go client for TiKV
Apache License 2.0
282 stars 222 forks source link

Fix the problem that adaptive update interval doesn't recovers back and there's too much logs about setting the config #1502

Closed MyonKeminta closed 1 week ago

MyonKeminta commented 1 week ago

Found and fixed these problems:

  1. As updating last tick time is moved into the doUpdate closure, and nextUpdateInterval calculates the value of recovering based on the last tick time, it causes the update interval unable to recover back.
  2. TiDB calls SetLowResolutionTimestampUpdateInterval every 30 seconds no matter whether the user changes it. After adding the log about changing the update interval, then there becomes too many logs.
ti-chi-bot[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, crazycs520

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tikv/client-go/blob/master/OWNERS)~~ [cfzjywxk,crazycs520] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 1 week ago

[LGTM Timeline notifier]

Timeline: