tikv / community

TiKV community content
43 stars 55 forks source link

vote: pingyu as TiKV committer #178

Closed iosmanthus closed 2 years ago

iosmanthus commented 2 years ago

Signed-off-by: iosmanthus myosmanthustree@gmail.com Rendered

Proposal

@pingyu has been working on tikv/tikv for 8 months. He has continuously contributed to storage and RawKV related components (api_version, causal_ts, etc.). His contributions are listed:

Authored pull requests Reviewed pull requests I (@iosmanthus) hereby nominate @pingyu as TiKV Committer and call for a vote.

ti-chi-bot commented 2 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
sunxiaoguang commented 2 years ago

/hold

sunxiaoguang commented 2 years ago

+1

Thanks for your contributions!

ti-chi-bot commented 2 years ago

@iosmanthus: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to [this](https://github.com/tikv/community/pull/178#issuecomment-1159746314): >/merge Instructions for interacting with me using PR comments are available [here](https://prow.tidb.io/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.
skyzh commented 2 years ago

/merge

ti-chi-bot commented 2 years ago

This pull request has been accepted and is ready to merge.

Commit hash: 26105c21971eb3e3b2eb54718721687c93daffb5

iosmanthus commented 2 years ago

/unhold