search

tikv / community

TiKV community content
43 stars 55 forks source link

Nominate dongxu as member of TOC #212

Closed sunxiaoguang closed 7 months ago

sunxiaoguang commented 7 months ago

Closes: #210

ti-chi-bot[bot] commented 7 months ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
sunxiaoguang commented 7 months ago

/hold

winkyao commented 7 months ago

+1

ti-chi-bot[bot] commented 7 months ago

@winkyao: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to [this](https://github.com/tikv/community/pull/212#pullrequestreview-1956363770): > Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.
sunxiaoguang commented 7 months ago

/unhold

sunxiaoguang commented 7 months ago

/merge

ti-chi-bot[bot] commented 7 months ago

This pull request has been accepted and is ready to merge.

Commit hash: 41f9a4c3a1279c8427b888ec427aa6b67e587c30