tikv / fail-rs

Fail points for rust
Apache License 2.0
338 stars 40 forks source link

Use rustup provided clippy. #13

Closed Hoverbear closed 6 years ago

Hoverbear commented 6 years ago

Also see: https://internals.rust-lang.org/t/clippy-is-available-as-a-rustup-component/7967

Move the clippy we use from being installed by cargo to being installed by rustup. If you find strange problems with clippy after they are merged you will need to do: cargo uninstall clippy && cargo uninstall clippy-lints && rustup self update

This is because the old versions of rustup don't know that clippy is managed, so they give errors like subcommand clippy does not exist.

Reasons for doing this:

Currently the clippy version must be managed separate from the Rust nightly. Using Rustup will allow each of our projects to depend on their own clippy versions and help avoid some toolchain related problems.

The PRs:

siddontang commented 6 years ago

PTAL @overvenus

siddontang commented 6 years ago

@overvenus please follow the rule to give LGTM or approve it