search

tikv / fail-rs

Fail points for rust
Apache License 2.0
338 stars 40 forks source link

*: format and lint code #18

Closed BusyJay closed 5 years ago

BusyJay commented 5 years ago

Keep consistent code style with latest stable rust.

brson commented 5 years ago

@BusyJay from my own local experimentation I think that .travis.yml needs to change for clippy as well: instead of passing -D clippy it should be -D clippy::all.

Without that change clippy gives an ominous warning:

    Checking fail v0.2.1 (/home/brian/pingcap/fail-rs)
warning: lint name `clippy` is deprecated and does not have an effect anymore. Use: clippy::all
  |
  = note: requested on the command line with `-D clippy`

    Finished dev [unoptimized + debuginfo] target(s) in 0.65s

So I think without that change, clippy is not doing the same aggressive checks it was previously. Can you also make that change as part of this PR?

BusyJay commented 5 years ago

Done, PTAL.