search

tikv / fail-rs

Fail points for rust
Apache License 2.0
332 stars 39 forks source link

Refine CI, use travis windows #32

Closed Hoverbear closed 5 years ago

Hoverbear commented 5 years ago

Adopts using the Travis CI windows boxes for CI. Adopts a nearly identical CI to https://github.com/pingcap/raft-rs/pull/190.

AAppveyor failure is expected and shouldn't prevent merge. We can turn off appveyor after.

kennytm commented 5 years ago

Note that the entire build now takes 16 minutes. The Windows machine on Travis takes 10 minutes to run (compared with 1 minute on AppVeyor) because Travis uses rustup and we've got the bug rust-lang/rustup.rs#1540.

Hoverbear commented 5 years ago

I noticed this as well. :(

brson commented 5 years ago

I know @nrc was working on the upstream rustup bug at one point. Maybe this is something one of us should go fix. It's been one of the biggest rustup issues and it's not all that hard to fix somehow.

nrc commented 5 years ago

I know @nrc was working on the upstream rustup bug at one point

I even have a PR, just needs some tests and some fixups. I guess this is motivation to get the damn thing finished

BusyJay commented 5 years ago

Aren't 9 CI checks too much for such a simple crate?