search

tikv / fail-rs

Fail points for rust
Apache License 2.0
338 stars 40 forks source link

"Put test cases exercising fail points into their own test crate" — is 'crate' right? #52

Open 8573 opened 4 years ago

8573 commented 4 years ago

The fail crate's crate-level doc-comment first says—

https://github.com/tikv/fail-rs/blob/2cf1175a1a5cc2c70bd20ebd45313afd69b558fc/src/lib.rs#L107-L108

—and then later says—

https://github.com/tikv/fail-rs/blob/2cf1175a1a5cc2c70bd20ebd45313afd69b558fc/src/lib.rs#L219-L220

Should the latter advice say "binary" rather than "crate"?

BusyJay commented 4 years ago

I think you are correct. What do you think? /cc @brson?