search

tikv / importer

tikv-importer is a front-end to help ingesting large number of KV pairs into a TiKV cluster
Apache License 2.0
20 stars 14 forks source link

Update TiKV; Fix validation failure when listening on 0.0.0.0. #20

Closed kennytm closed 4 years ago

kennytm commented 5 years ago

What have you changed? (mandatory)

  1. Forward-port #18 to fix the missing logs. Update TiKV to latest master.
  2. When importer listens on 0.0.0.0, the config validation will fail since the server.addr config is copied to server.advertise-addr and the latter explicitly bans 0.0.0.0. We workaround by setting this field to a dummy value since Importer doesn't expose itself to PD yet.

What are the type of the changes? (mandatory)

How has this PR been tested? (mandatory)

Manually executed.

Does this PR affect TiDB Lightning? (mandatory)

No

Refer to a related PR or issue link (optional)

18

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

kennytm commented 5 years ago

/run-all-tests

lance6716 commented 5 years ago

LGTM

kennytm commented 5 years ago

PTAL @leoppro

zhouqiang-cl commented 5 years ago

@kennytm It last too long...

kennytm commented 4 years ago

PTAL again @overvenus thanks. Removed the TIKV_EXTRA_LOG_TARGETS hack and updated TiKV to latest master version.