config,engine: use the entire [rocksdb] section to config the engines - Githubissues

tikv / importer

tikv-importer is a front-end to help ingesting large number of KV pairs into a TiKV cluster

Apache License 2.0

20 stars 14 forks source link

config,engine: use the entire [rocksdb] section to config the engines #45

Closed kennytm closed 4 years ago

kennytm commented 4 years ago

What have you changed? (mandatory)

Previously only a few config was recognized when tuning the RocksDB used in engine files.

This PR instead uses the entire [rocksdb] config. This allows us to test performance for other options such as using Titan.

What are the type of the changes? (mandatory)

Improvement (change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

Unit test

Does this PR affect TiDB Lightning? (mandatory)

No

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

kennytm commented 4 years ago

/release

sre-bot commented 4 years ago

download tikv at http://fileserver.pingcap.net/download/builds/tikv-importer/pr/f8dbe61293973b8278dd5c1d31c723076927c9c5/centos7/tikv-importer.tar.gz

kennytm commented 4 years ago

(No performance improvement with Titan.)

kennytm commented 4 years ago

the status is messed up, i'll create another PR for this.