search

tikv / importer

tikv-importer is a front-end to help ingesting large number of KV pairs into a TiKV cluster
Apache License 2.0
20 stars 14 forks source link

*: Use lower version of openssl and make more functions async #89

Closed kennytm closed 3 years ago

kennytm commented 3 years ago

What have you changed? (mandatory)

1. Use the same locked OpenSSL version as TiKV (1.1.1g) instead of the latest one (1.1.1i)

Fix this error when connecting to importer:

[2020-12-28T03:23:43.689Z] [2020/12/28 11:23:39.020 +08:00] [ERROR] [<unknown>] ["Handshake failed with fatal error SSL_ERROR_SSL: error:1417C086:SSL routines:tls_process_client_certificate:certificate verify failed."]

We may need to check the cert generation algorithm in Lightning to ensure nothing goes wrong when we actually upgrade OpenSSL to 1.1.1i.

2. Make more functions relying on block_on as async, to avoid the EnterError when using block_on inside an async context.

What are the type of the changes? (mandatory)

How has this PR been tested? (mandatory)

run the Lightning integration test various_types.

Does this PR affect TiDB Lightning? (mandatory)

No

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

overvenus commented 3 years ago

LGTM

kennytm commented 3 years ago

Blocked by cherry-pick of tikv/tikv#9390 to release-5.0-rc.

kennytm commented 3 years ago

/cc @glorv @overvenus

jebter commented 3 years ago

/run-all-test

Little-Wallace commented 3 years ago

/merge

zhouqiang-cl commented 3 years ago

/merge