tikv / jemallocator

Rust allocator using jemalloc as a backend
Other
364 stars 62 forks source link

Feature `disable_cache_oblivious` not exported #103

Closed miried closed 1 month ago

miried commented 1 month ago

According to the README, "The tikv-jemallocator crate re-exports the features of the tikv-jemalloc-sys dependency".

tikv-jemalloc-sys has a feature flag called disable_cache_oblivious, but it including it in the tikv-jemallocator entry in Cargo.toml leads to an error, because it looks like it does not actually re-export the feature.

Is this intentional? Can the feature be used by including tikv-jemalloc-sys directly in the project? Or does it need to be fixed?

BusyJay commented 1 month ago

The doc is not accurate anymore. tikv-jemallocator also has its own features. But yes, it should be more convenient to reexports all tikv-jemalloc-sys' features. I'm open for a pull request.

Can the feature be used by including tikv-jemalloc-sys directly in the project?

Yes, it is a workaround.