search

tikv / jemallocator

Rust allocator using jemalloc as a backend
Other
364 stars 62 forks source link

chore: update jemalloc version #87

Closed Rjected closed 6 months ago

Rjected commented 6 months ago

It would be great to bump the jemalloc version since newer versions support profiling on macOS!

BusyJay commented 6 months ago

Let's wait till it's officially released.

Rjected commented 6 months ago

Let's wait till it's officially released.

unfortunately I'm not sure if that will happen any time soon: https://github.com/jemalloc/jemalloc/issues/2604

In the case that jemalloc does not release in the next ~year, would there be an acceptable policy to adopt for bumping jemalloc versions, specifically validating that the bumped version is "good", w.r.t stability, testing, and benchmarking?

Maybe we could wait for the production tested commits?

Although even that seems to be updating at a slow pace

BusyJay commented 6 months ago

As this project is used widely in Rust ecosystem (directly or indirectly), I prefer to take a more conservative move. I'm aware of and have been watching the issue, but as the issue says, the listed commits are only verified on limited platforms and potentially break between commits.

BusyJay commented 6 months ago

Adding an issue to allow users to switch to dev code if they want: https://github.com/tikv/jemallocator/issues/88

Rjected commented 6 months ago

As this project is used widely in Rust ecosystem (directly or indirectly), I prefer to take a more conservative move. I'm aware of and have been watching the issue, but as the issue says, the listed commits are only verified on limited platforms and potentially break between commits.

that makes sense, the issue looks like it would solve this use case so I'll close the PR