search

tikv / jemallocator

Rust allocator using jemalloc as a backend
Other
347 stars 58 forks source link

cherry-pick from upstream jemalloc to fix profiling bug #9

Closed umanwizard closed 3 years ago

umanwizard commented 3 years ago

This depends on https://github.com/tikv/jemalloc/pull/2 , which is a cherry-pick of https://github.com/jemalloc/jemalloc/pull/1604 .

See https://github.com/jemalloc/jemalloc/issues/1605 for details of the bug that this fixes; basically, it makes profiling/sampling fail to work under some conditions. We hit this in practice at Materialize when attempting to switch to tikv/jemallocator.

umanwizard commented 3 years ago

@BusyJay , @sticnarf , this is ready for a look now that tikv/jemalloc#2 has landed.

BusyJay commented 3 years ago

Travis CI is out of quota, I may need some time to migrate to github actions.

BusyJay commented 3 years ago

New CI can be triggered once it's merged master.

umanwizard commented 3 years ago

I have reverted the configure change and rebased on latest master.

umanwizard commented 3 years ago

Unfortunately, this broke tikv/jemallocator, since tikv/jemalloc#2 landed with a different commit number. Sending a new PR now.

umanwizard commented 3 years ago

Fixed in https://github.com/tikv/jemallocator/pull/12