Closed xiaojingchen closed 5 years ago
What did you do? When I deploy TiDB cluster by TiDB operator on K8s, I want to use the labels which have been set in K8s node, but current PD does not support label which contains \. e.g:failure-domain.beta.kubernetes.io/region
\
failure-domain.beta.kubernetes.io/region
What did you expect to see? PD supports the label which matches K8s's label style. ref: https://kubernetes.io/docs/reference/kubernetes-api/labels-annotations-taints/
Thanks for your feedback, I will check about this.
related: https://github.com/pingcap/pd/pull/1154
the k8s style: https://github.com/kubernetes/apimachinery/blob/master/pkg/util/validation/validation.go#L42
What did you do? When I deploy TiDB cluster by TiDB operator on K8s, I want to use the labels which have been set in K8s node, but current PD does not support label which contains
\
. e.g:failure-domain.beta.kubernetes.io/region
What did you expect to see? PD supports the label which matches K8s's label style. ref: https://kubernetes.io/docs/reference/kubernetes-api/labels-annotations-taints/