tikv / pd

Placement driver for TiKV

Apache License 2.0

1.05k stars 720 forks source link

Clean up the deprecated codes #4679

Open rleungx opened 2 years ago

rleungx commented 2 years ago

Enhancement Task

We have many deprecated codes which have been kept for a long time. We can clean them up.

mahjonp commented 2 years ago

Sadly said that tidb-operator has failed to deploy because of #4678. @rleungx

E0226 14:19:12.913749       1 pd_member_manager.go:188] failed to sync TidbCluster: [endless-oltp-tps-604649-1-698/tc]'s status, error: Error response 404 URL http://tc-pd.endless-oltp-tps-604649-1-698:2379/pd/health,body response: 404 page not found

overvenus commented 2 years ago

4678 also breaks TiCDC integration tests.

See https://github.com/pingcap/tiflow/pull/4686/commits/71be3b3b4dfa0106daf1d3f2d16813fa67ff115f

lhy1024 commented 1 year ago

I think we can mark deprecated to enable-*-replica, which only is valid for replica-checker, since we use placement-rules as default in 5.0.