tikv / pd

Placement driver for TiKV
Apache License 2.0
1.03k stars 714 forks source link

grpc_service: add `ManuallyChangePeer` and `ManuallyChangeMultiPeers`. #8266

Closed LykxSassinator closed 2 weeks ago

LykxSassinator commented 3 weeks ago

What problem does this PR solve?

Issue Number: Ref https://github.com/tikv/tikv/issues/15292 proto: https://github.com/pingcap/kvproto/pull/1250

What is changed and how does it work?

Make `grpc_service` support manually add / remove peers by `ManuallyChangePeer` and `ManuallyChangeMultiPeers`.

Check List

Tests

Code changes

Side effects

Related changes

Release note

Add extra apis `ManuallyChangePeer` and `ManuallyChangeMultiPeers` for `grpc_service` to support manually add / remove peers.
ti-chi-bot[bot] commented 3 weeks ago

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
LykxSassinator commented 3 weeks ago

/cc @nolouch

ti-chi-bot[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign lhy1024 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/tikv/pd/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 2 weeks ago

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456, multiple issues should use full syntax for each issue and be separated by a comma, like: Issue Number: close #123, ref #456.

:open_book: For more info, you can check the "Linking issues" section in the CONTRIBUTING.md.

LykxSassinator commented 2 weeks ago

This pr can be closed as this RPC is not necessary.