rc: fix group change will meet data race

HuSharp commented 3 months ago

What problem does this PR solve?

Issue Number: Close #8267

What is changed and how does it work?

Because there is no happens-before guarantee for different goroutine, maybe meet memory reordering

Check List

Tests

No code(Cannot test it for memory ordering :( )

Release note

None.

ti-chi-bot[bot] commented 3 months ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.31%. Comparing base (e767c01) to head (b5a4f5c).

:exclamation: Current head b5a4f5c differs from pull request most recent head 0b7d0b9

Please upload reports for the commit 0b7d0b9 to get more accurate results.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #8268 +/- ## ========================================== - Coverage 77.33% 77.31% -0.03% ========================================== Files 471 471 Lines 61381 61382 +1 ========================================== - Hits 47472 47458 -14 - Misses 10359 10371 +12 - Partials 3550 3553 +3 ``` | [Flag](https://app.codecov.io/gh/tikv/pd/pull/8268/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/tikv/pd/pull/8268/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | `77.31% <100.00%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#carryforward-flags-in-the-pull-request-comment) to find out more.

HuSharp commented 3 months ago

/test ?

ti-chi-bot[bot] commented 3 months ago

@HuSharp: The following commands are available to trigger required jobs:

/test build

The following commands are available to trigger optional jobs:

/test pull-integration-copr-test
/test pull-integration-realcluster-test

Use /test all to run the following jobs that were automatically triggered:

tikv/pd/ghpr_build

In response to [this](https://github.com/tikv/pd/pull/8268#issuecomment-2153986643): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

HuSharp commented 3 months ago

/test pull-integration-realcluster-test

ti-chi-bot[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, nolouch, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tikv/pd/blob/master/OWNERS)~~ [lhy1024,nolouch,rleungx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ti-chi-bot[bot] commented 3 months ago

[LGTM Timeline notifier]

Timeline:

2024-06-11 02:54:23.602464837 +0000 UTC m=+433217.655776762: :ballot_box_with_check: agreed by rleungx.
2024-06-11 05:12:32.111236822 +0000 UTC m=+441506.164548745: :ballot_box_with_check: agreed by nolouch.

HuSharp commented 3 months ago

/run-cherry-picker

HuSharp commented 3 months ago

/run-cherry-picker

ti-chi-bot commented 3 months ago

In response to a cherrypick label: new pull request created to branch release-7.5: #8292.

ti-chi-bot commented 3 months ago

In response to a cherrypick label: new pull request created to branch release-8.1: #8293.

ti-chi-bot commented 3 months ago

In response to a cherrypick label: new pull request created to branch release-7.1: #8294.

tikv / pd