tikv / pd

Placement driver for TiKV
Apache License 2.0
1.03k stars 714 forks source link

tests/realcluster: using real pd with race #8270

Closed HuSharp closed 3 weeks ago

HuSharp commented 3 weeks ago

What problem does this PR solve?

Issue Number: Ref #7298

What is changed and how does it work?

running with data race

Check List

Tests

Release note

None.
ti-chi-bot[bot] commented 3 weeks ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
HuSharp commented 3 weeks ago

/test ?

ti-chi-bot[bot] commented 3 weeks ago

@HuSharp: The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/tikv/pd/pull/8270#issuecomment-2153958034): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
HuSharp commented 3 weeks ago

/test pull-integration-realcluster-test

HuSharp commented 3 weeks ago

Ref #8263, #8267

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.33%. Comparing base (494c0e9) to head (2be4512).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8270 +/- ## ========================================== + Coverage 77.30% 77.33% +0.02% ========================================== Files 471 471 Lines 61380 61380 ========================================== + Hits 47451 47466 +15 + Misses 10373 10366 -7 + Partials 3556 3548 -8 ``` | [Flag](https://app.codecov.io/gh/tikv/pd/pull/8270/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/tikv/pd/pull/8270/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | `77.33% <ø> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#carryforward-flags-in-the-pull-request-comment) to find out more.
HuSharp commented 3 weeks ago

/merge

ti-chi-bot[bot] commented 3 weeks ago

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 3 weeks ago

This pull request has been accepted and is ready to merge.

Commit hash: 2be4512c2850ecedcdd3e4da8905024f6b675cd4

ti-chi-bot commented 2 weeks ago

In response to a cherrypick label: new pull request created to branch release-8.1: #8295.

ti-chi-bot commented 2 weeks ago

In response to a cherrypick label: new pull request created to branch release-7.5: #8296.

ti-chi-bot commented 2 weeks ago

In response to a cherrypick label: new pull request created to branch release-7.1: #8297.