tikv / pd

Placement driver for TiKV
Apache License 2.0
1.03k stars 714 forks source link

*: enable errcheck #8277

Closed okJiang closed 2 weeks ago

okJiang commented 3 weeks ago

What problem does this PR solve?

Issue Number: Ref https://github.com/tikv/pd/issues/1919

What is changed and how does it work?

Check List

Tests

Code changes

Side effects

Related changes

Release note

None.
codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 47.22222% with 19 lines in your changes missing coverage. Please review.

Project coverage is 77.28%. Comparing base (9dff6e6) to head (b2b5ab6). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8277 +/- ## ========================================== - Coverage 77.35% 77.28% -0.08% ========================================== Files 470 470 Lines 61376 61385 +9 ========================================== - Hits 47478 47439 -39 - Misses 10336 10388 +52 + Partials 3562 3558 -4 ``` | [Flag](https://app.codecov.io/gh/tikv/pd/pull/8277/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/tikv/pd/pull/8277/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | `77.28% <47.22%> (-0.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#carryforward-flags-in-the-pull-request-comment) to find out more.
okJiang commented 2 weeks ago

/retest

JmPotato commented 2 weeks ago

/merge

ti-chi-bot[bot] commented 2 weeks ago

@JmPotato: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want approve this pull request.

The changes announcement: Proposal: Strengthen configuration change approval.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.
JmPotato commented 2 weeks ago

/approve

ti-chi-bot[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tikv/pd/blob/master/OWNERS)~~ [JmPotato,rleungx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 2 weeks ago

[LGTM Timeline notifier]

Timeline:

rleungx commented 2 weeks ago

/merge

ti-chi-bot[bot] commented 2 weeks ago

@rleungx: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want approve this pull request.

The changes announcement: Proposal: Strengthen configuration change approval.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.