tikv / pd

Placement driver for TiKV
Apache License 2.0
1.03k stars 714 forks source link

server, metrics: let server TSO handle duration including failed requests #8282

Closed JmPotato closed 2 weeks ago

JmPotato commented 2 weeks ago

What problem does this PR solve?

Issue Number: ref #8281.

What is changed and how does it work?

- Delete the 99.999% percentile data because it does not correspond with TiDB and is too tail-end, which can easily mislead.
- Emphasize PD server/client in the panel title.
- Add corresponding 90/99/99.9% percentile data on the client handle duration for easier comparison.
- The PD server TSO handle duration now includes the failed requests, directly reflecting TSO HA anomalies in the monitoring data.

Check List

Tests

image

Release note

Let PD server TSO handle duration including failed requests.
codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.31%. Comparing base (c75e98b) to head (00b6aa7).

:exclamation: Current head 00b6aa7 differs from pull request most recent head 1f8826f

Please upload reports for the commit 1f8826f to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8282 +/- ## ========================================== + Coverage 77.27% 77.31% +0.03% ========================================== Files 471 471 Lines 61395 61395 ========================================== + Hits 47446 47466 +20 + Misses 10395 10378 -17 + Partials 3554 3551 -3 ``` | [Flag](https://app.codecov.io/gh/tikv/pd/pull/8282/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/tikv/pd/pull/8282/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | `77.31% <100.00%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#carryforward-flags-in-the-pull-request-comment) to find out more.
ti-chi-bot[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndreMouche, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tikv/pd/blob/master/OWNERS)~~ [AndreMouche,rleungx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 2 weeks ago

[LGTM Timeline notifier]

Timeline:

JmPotato commented 2 weeks ago

/merge