tikv / pd

Placement driver for TiKV
Apache License 2.0
1.03k stars 714 forks source link

mcs: tso server compare address without scheme #8283

Closed lhy1024 closed 2 weeks ago

lhy1024 commented 2 weeks ago

What problem does this PR solve?

Issue Number: Close #8284

What is changed and how does it work?

Check List

Tests

Release note

None.
ti-chi-bot[bot] commented 2 weeks ago

@iosmanthus: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/tikv/pd/pull/8283#pullrequestreview-2115161305): >Rest LGTM Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 2 weeks ago

@iosmanthus: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/tikv/pd/pull/8283#pullrequestreview-2115215868): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.29%. Comparing base (14c68f6) to head (5314ac9).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8283 +/- ## ========================================== - Coverage 77.42% 77.29% -0.13% ========================================== Files 471 471 Lines 61405 61411 +6 ========================================== - Hits 47540 47468 -72 - Misses 10308 10385 +77 - Partials 3557 3558 +1 ``` | [Flag](https://app.codecov.io/gh/tikv/pd/pull/8283/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/tikv/pd/pull/8283/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | `77.29% <100.00%> (-0.13%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#carryforward-flags-in-the-pull-request-comment) to find out more.
ti-chi-bot[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, iosmanthus, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tikv/pd/blob/master/OWNERS)~~ [HuSharp,rleungx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 2 weeks ago

[LGTM Timeline notifier]

Timeline: