tikv / pd

Placement driver for TiKV
Apache License 2.0
1.03k stars 714 forks source link

*: enable error check for mcs, keyspace and labeler #8288

Closed rleungx closed 2 weeks ago

rleungx commented 2 weeks ago

What problem does this PR solve?

Issue Number: Ref #1919.

What is changed and how does it work?

Check List

Tests

Release note

None.
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 77.31%. Comparing base (463aee9) to head (e541372).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8288 +/- ## ========================================== - Coverage 77.39% 77.31% -0.08% ========================================== Files 470 470 Lines 61387 61392 +5 ========================================== - Hits 47508 47464 -44 - Misses 10315 10372 +57 + Partials 3564 3556 -8 ``` | [Flag](https://app.codecov.io/gh/tikv/pd/pull/8288/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/tikv/pd/pull/8288/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | `77.31% <14.28%> (-0.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#carryforward-flags-in-the-pull-request-comment) to find out more.
ti-chi-bot[bot] commented 2 weeks ago

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/tikv/pd/pull/8288#pullrequestreview-2117773146): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tikv/pd/blob/master/OWNERS)~~ [HuSharp] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 2 weeks ago

[LGTM Timeline notifier]

Timeline:

rleungx commented 2 weeks ago

/merge

ti-chi-bot[bot] commented 2 weeks ago

@rleungx: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want approve this pull request.

The changes announcement: Proposal: Strengthen configuration change approval.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.