search

tikv / pd

Placement driver for TiKV
Apache License 2.0
1.03k stars 714 forks source link

mcs: fix tso server address compare #8289

Closed lhy1024 closed 1 week ago

lhy1024 commented 2 weeks ago

What problem does this PR solve?

Issue Number: Close https://github.com/tikv/pd/issues/8284

What is changed and how does it work?

Check List

Tests

After 

root@serverless-cluster-pd-2:/# curl -s http://127.0.0.1:2379/pd/api/v2/tso/keyspace-groups | jq '.[0].members'
[
  {
    "address": "http://pd-tso-server-0.tso-service.tidb-serverless.svc:2379/",
    "priority": 200
  },
  {
    "address": "http://pd-tso-server-1.tso-service.tidb-serverless.svc:2379/",
    "priority": 300
  }
]
root@serverless-cluster-pd-2:/# curl -k http://127.0.0.1:2379/pd/api/v2/ms/members/tso
[
    {
        "service-addr": "https://pd-tso-server-0.tso-service.tidb-serverless.svc:2379/",
        "version": "v7.1.1-serverless",
        "git-hash": "592e1d8525896dc6e0c2f91b4991de11c86353fc",
        "deploy-path": "/pd-server",
        "start-timestamp": 1718952710
    },
    {
        "service-addr": "https://pd-tso-server-1.tso-service.tidb-serverless.svc:2379/",
        "version": "v7.1.1-serverless",
        "git-hash": "592e1d8525896dc6e0c2f91b4991de11c86353fc",
        "deploy-path": "/pd-server",
        "start-timestamp": 1718952694
    }
]

Release note

None.
codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.45%. Comparing base (26e90e9) to head (54255c2).

:exclamation: Current head 54255c2 differs from pull request most recent head 2686731

Please upload reports for the commit 2686731 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8289 +/- ## ========================================== + Coverage 77.31% 77.45% +0.14% ========================================== Files 470 470 Lines 61517 61385 -132 ========================================== - Hits 47561 47547 -14 + Misses 10394 10283 -111 + Partials 3562 3555 -7 ``` | [Flag](https://app.codecov.io/gh/tikv/pd/pull/8289/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/tikv/pd/pull/8289/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | `77.45% <100.00%> (+0.14%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#carryforward-flags-in-the-pull-request-comment) to find out more.
ti-chi-bot[bot] commented 1 week ago

@lhy1024: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-realcluster-test 2686731a6e21f1bfcef1f2c32ea001fa5ed0e157 link false /test pull-integration-realcluster-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
ti-chi-bot[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tikv/pd/blob/master/OWNERS)~~ [JmPotato,rleungx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 1 week ago

[LGTM Timeline notifier]

Timeline: