tikv / pd

Placement driver for TiKV
Apache License 2.0
1.03k stars 714 forks source link

*: enable error check for some files #8301

Closed okJiang closed 1 week ago

okJiang commented 2 weeks ago

What problem does this PR solve?

Issue Number: Ref https://github.com/tikv/pd/issues/1919

What is changed and how does it work?

Check List

Tests

Code changes

Side effects

Related changes

Release note

None.
okJiang commented 2 weeks ago

/retest

okJiang commented 2 weeks ago

/retest

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.

Project coverage is 77.32%. Comparing base (463aee9) to head (2c4a203). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8301 +/- ## ========================================== - Coverage 77.39% 77.32% -0.07% ========================================== Files 470 470 Lines 61387 61356 -31 ========================================== - Hits 47508 47443 -65 - Misses 10315 10342 +27 - Partials 3564 3571 +7 ``` | [Flag](https://app.codecov.io/gh/tikv/pd/pull/8301/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/tikv/pd/pull/8301/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | `77.32% <61.11%> (-0.07%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#carryforward-flags-in-the-pull-request-comment) to find out more.
ti-chi-bot[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tikv/pd/blob/master/OWNERS)~~ [HuSharp,rleungx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 1 week ago

[LGTM Timeline notifier]

Timeline: