tikv / pd

Placement driver for TiKV
Apache License 2.0
1.03k stars 714 forks source link

mcs: update node every restart #8302

Closed rleungx closed 1 week ago

rleungx commented 2 weeks ago

What problem does this PR solve?

Issue Number: Close #8154

What is changed and how does it work?

Check List

Tests

Release note

None.
codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.38%. Comparing base (89ca8df) to head (90a3518).

:exclamation: Current head 90a3518 differs from pull request most recent head 9a0938a

Please upload reports for the commit 9a0938a to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8302 +/- ## ========================================== - Coverage 77.41% 77.38% -0.03% ========================================== Files 470 470 Lines 61356 61395 +39 ========================================== + Hits 47499 47512 +13 - Misses 10296 10329 +33 + Partials 3561 3554 -7 ``` | [Flag](https://app.codecov.io/gh/tikv/pd/pull/8302/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/tikv/pd/pull/8302/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | `77.38% <100.00%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#carryforward-flags-in-the-pull-request-comment) to find out more.
rleungx commented 1 week ago

/cc @iosmanthus

ti-chi-bot[bot] commented 1 week ago

@rleungx: GitHub didn't allow me to request PR reviews from the following users: iosmanthus.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/tikv/pd/pull/8302#issuecomment-2174837417): >/cc @iosmanthus Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tikv/pd/blob/master/OWNERS)~~ [JmPotato,lhy1024] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 1 week ago

[LGTM Timeline notifier]

Timeline: