tikv / pd

Placement driver for TiKV
Apache License 2.0
1.03k stars 714 forks source link

scheduler: skip evict-leader-scheduler when setting schedule deny label #8303

Closed okJiang closed 1 week ago

okJiang commented 2 weeks ago

What problem does this PR solve?

Issue Number: Close https://github.com/tikv/pd/issues/7853 ref https://github.com/tikv/pd/issues/7300

What is changed and how does it work?

- add a real cluster test to test `skip evict-leader-scheduler when setting schedule deny label`
- add `DeleteStoreLabel` API and `DeleteScheduler` API

Check List

Tests

Code changes

Side effects

Related changes

Release note

None.
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.34%. Comparing base (debb5fe) to head (fa47700).

:exclamation: Current head fa47700 differs from pull request most recent head f981b69

Please upload reports for the commit f981b69 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8303 +/- ## ========================================== + Coverage 77.30% 77.34% +0.03% ========================================== Files 470 470 Lines 61500 61377 -123 ========================================== - Hits 47545 47469 -76 + Misses 10393 10354 -39 + Partials 3562 3554 -8 ``` | [Flag](https://app.codecov.io/gh/tikv/pd/pull/8303/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/tikv/pd/pull/8303/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | `77.34% <72.22%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#carryforward-flags-in-the-pull-request-comment) to find out more.
HuSharp commented 1 week ago

/test ?

ti-chi-bot[bot] commented 1 week ago

@HuSharp: The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/tikv/pd/pull/8303#issuecomment-2175387465): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
HuSharp commented 1 week ago

/test pull-integration-realcluster-test

okJiang commented 1 week ago

/test pull-integration-realcluster-test

okJiang commented 1 week ago

/test pull-integration-realcluster-test

okJiang commented 1 week ago

strange error https://do.pingcap.net/jenkins/blue/rest/organizations/jenkins/pipelines/tikv/pipelines/pd/pipelines/pull_integration_realcluster_test/runs/45/nodes/72/steps/77/log/?start=0

okJiang commented 1 week ago

/test pull-integration-realcluster-test

okJiang commented 1 week ago

ptal~ ci passed @HuSharp @rleungx

HuSharp commented 1 week ago

ci failed, Can you test this PR with lightning/br and paste a picture to indicate the change?

okJiang commented 1 week ago

ci failed, Can you test this PR with lightning/br and paste a picture to indicate the change?

I think realcluster test is enough for this pr😂 It's not really worth spending a lot of time making specific changes for this requirement to do e2e testing. It's completely sufficient to know that evict leader still works when calling the API.

ti-chi-bot[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tikv/pd/blob/master/OWNERS)~~ [HuSharp,rleungx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 1 week ago

[LGTM Timeline notifier]

Timeline: