tikv / pd

Placement driver for TiKV
Apache License 2.0
1.03k stars 714 forks source link

*: add mark function for log desensitization #8306

Closed JmPotato closed 20 minutes ago

JmPotato commented 1 week ago

What problem does this PR solve?

Issue Number: ref #8305.

What is changed and how does it work?

Provide sensitive log redact marker `‹..›` to customize log desensitization.

Check List

Tests

image

Release note

Provide sensitive log redact marker `‹..›` to customize log desensitization.
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 84.70588% with 13 lines in your changes missing coverage. Please review.

Project coverage is 77.37%. Comparing base (e7c9d15) to head (0a4f215).

:exclamation: Current head 0a4f215 differs from pull request most recent head bc2c7d3

Please upload reports for the commit bc2c7d3 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8306 +/- ## ========================================== + Coverage 77.23% 77.37% +0.13% ========================================== Files 470 470 Lines 61572 61404 -168 ========================================== - Hits 47558 47513 -45 + Misses 10426 10324 -102 + Partials 3588 3567 -21 ``` | [Flag](https://app.codecov.io/gh/tikv/pd/pull/8306/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/tikv/pd/pull/8306/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | `77.37% <84.70%> (+0.13%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#carryforward-flags-in-the-pull-request-comment) to find out more.
ti-chi-bot[bot] commented 1 week ago

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/tikv/pd/pull/8306#pullrequestreview-2127348185): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 6 hours ago

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/tikv/pd/pull/8306#pullrequestreview-2150338674): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 4 hours ago

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/tikv/pd/pull/8306#pullrequestreview-2150446107): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 2 hours ago

[LGTM Timeline notifier]

Timeline:

JmPotato commented 2 hours ago

nit: Can you add to the pr description the log display for different log settings?

Pasted. PTAL.

/approve

ti-chi-bot[bot] commented 21 minutes ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, JmPotato, niubell, okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tikv/pd/blob/master/OWNERS)~~ [HuSharp,JmPotato,rleungx] - ~~[conf/OWNERS](https://github.com/tikv/pd/blob/master/conf/OWNERS)~~ [niubell] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment