tikv / pd

Placement driver for TiKV
Apache License 2.0
1.03k stars 714 forks source link

tests/real_cluster: refine reboot cluster #8311

Closed HuSharp closed 1 week ago

HuSharp commented 1 week ago

What problem does this PR solve?

Issue Number: Close #8310

What is changed and how does it work?

When store.Store.Labels is zero, it may not serve the purpose of the test

Check List

Tests

None.
HuSharp commented 1 week ago

/cc @okJiang

ti-chi-bot[bot] commented 1 week ago

@HuSharp: GitHub didn't allow me to request PR reviews from the following users: okJiang.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/tikv/pd/pull/8311#issuecomment-2179873855): >/cc @okJiang Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.35%. Comparing base (9804702) to head (b3492ec).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8311 +/- ## ========================================== + Coverage 77.29% 77.35% +0.05% ========================================== Files 470 470 Lines 61360 61360 ========================================== + Hits 47431 47467 +36 + Misses 10369 10327 -42 - Partials 3560 3566 +6 ``` | [Flag](https://app.codecov.io/gh/tikv/pd/pull/8311/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/tikv/pd/pull/8311/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | `77.35% <ø> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#carryforward-flags-in-the-pull-request-comment) to find out more.
okJiang commented 1 week ago

/test pull-integration-realcluster-test

ti-chi-bot[bot] commented 1 week ago

@okJiang: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/tikv/pd/pull/8311#issuecomment-2179900360): > >/test pull-integration-realcluster-test > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
okJiang commented 1 week ago

/test pull-integration-realcluster-test

ti-chi-bot[bot] commented 1 week ago

[LGTM Timeline notifier]

Timeline:

ti-chi-bot[bot] commented 1 week ago

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/tikv/pd/pull/8311#pullrequestreview-2129854381): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tikv/pd/blob/master/OWNERS)~~ [JmPotato] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment