*: enable errcheck for server/*.go except server/api

okJiang commented 1 week ago

What problem does this PR solve?

Issue Number: Ref https://github.com/tikv/pd/issues/1919

What is changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has the configuration change
Has HTTP API interfaces changed (Don't forget to add the declarative for the new API)
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
PR to update pingcap/tiup:
Need to cherry-pick to the release branch

Release note

None.

okJiang commented 1 week ago

/cc @JmPotato @HuSharp

okJiang commented 4 days ago

Can you take a look again? Thanks! @JmPotato @rleungx @HuSharp

ti-chi-bot[bot] commented 4 days ago

[LGTM Timeline notifier]

Timeline:

2024-06-27 07:06:19.518807219 +0000 UTC m=+876106.004296051: :ballot_box_with_check: agreed by rleungx.
2024-06-27 09:37:32.08624861 +0000 UTC m=+885178.571737443: :ballot_box_with_check: agreed by JmPotato.

JmPotato commented 4 days ago

/merge

ti-chi-bot[bot] commented 4 days ago

@JmPotato: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want approve this pull request.

The changes announcement: Proposal: Strengthen configuration change approval.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.

JmPotato commented 4 days ago

/approve

ti-chi-bot[bot] commented 4 days ago

@okJiang: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.

rleungx commented 4 days ago

/approve

ti-chi-bot[bot] commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, niubell, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tikv/pd/blob/master/OWNERS)~~ [JmPotato,rleungx] - ~~[pkg/mcs/resourcemanager/server/OWNERS](https://github.com/tikv/pd/blob/master/pkg/mcs/resourcemanager/server/OWNERS)~~ [niubell] - ~~[pkg/mcs/scheduling/server/config/OWNERS](https://github.com/tikv/pd/blob/master/pkg/mcs/scheduling/server/config/OWNERS)~~ [niubell] - ~~[pkg/mcs/tso/server/OWNERS](https://github.com/tikv/pd/blob/master/pkg/mcs/tso/server/OWNERS)~~ [niubell] - ~~[server/config/OWNERS](https://github.com/tikv/pd/blob/master/server/config/OWNERS)~~ [niubell] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

tikv / pd