*: enable errcheck for schedulers

tikv / pd

Placement driver for TiKV

Apache License 2.0

1.03k stars 714 forks source link

*: enable errcheck for schedulers #8322

Closed rleungx closed 6 days ago

rleungx commented 1 week ago

What problem does this PR solve?

Issue Number: Ref #1919.

What is changed and how does it work?

Check List

Tests

Unit test

Release note

None.

ti-chi-bot[bot] commented 6 days ago

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/tikv/pd/pull/8322#pullrequestreview-2137253424): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

ti-chi-bot[bot] commented 6 days ago

[LGTM Timeline notifier]

Timeline:

2024-06-24 06:28:19.012806056 +0000 UTC m=+614625.498294904: :ballot_box_with_check: agreed by lhy1024.
2024-06-25 09:44:05.435020555 +0000 UTC m=+712771.920509380: :ballot_box_with_check: agreed by HuSharp.

rleungx commented 6 days ago

/merge

ti-chi-bot[bot] commented 6 days ago

@rleungx: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want approve this pull request.

The changes announcement: Proposal: Strengthen configuration change approval.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.

ti-chi-bot[bot] commented 6 days ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: HuSharp, lhy1024, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tikv/pd/blob/master/OWNERS)~~ [HuSharp,lhy1024] - **[pkg/schedule/schedulers/OWNERS](https://github.com/tikv/pd/blob/master/pkg/schedule/schedulers/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment