tikv / pd

Placement driver for TiKV
Apache License 2.0
1.03k stars 714 forks source link

config: fix the panic caused by zero RegionSplitSizeMB #8324

Closed JmPotato closed 6 days ago

JmPotato commented 6 days ago

What problem does this PR solve?

Issue Number: close #8323.

What is changed and how does it work?

Bypass the case that `RegionSplitSizeMB` might be zero in `(*StoreConfig) CheckRegionSize`.

Check List

Tests

Release note

None.
ti-chi-bot[bot] commented 6 days ago

[LGTM Timeline notifier]

Timeline:

JmPotato commented 6 days ago

/hold

JmPotato commented 6 days ago

/unhold

ti-chi-bot[bot] commented 6 days ago

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/tikv/pd/pull/8324#pullrequestreview-2138059683): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 6 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, niubell, nolouch, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tikv/pd/blob/master/OWNERS)~~ [HuSharp,nolouch] - ~~[pkg/schedule/config/OWNERS](https://github.com/tikv/pd/blob/master/pkg/schedule/config/OWNERS)~~ [niubell] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot commented 6 days ago

In response to a cherrypick label: new pull request created to branch release-8.1: #8325.

ti-chi-bot commented 6 days ago

In response to a cherrypick label: new pull request created to branch release-7.5: #8326.

ti-chi-bot commented 6 days ago

In response to a cherrypick label: new pull request created to branch release-6.5: #8327.

ti-chi-bot commented 6 days ago

In response to a cherrypick label: new pull request created to branch release-7.1: #8328.

ti-chi-bot commented 5 days ago

In response to a cherrypick label: new pull request created to branch release-6.1: #8329.